Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --ansi option #16

Merged
merged 3 commits into from
Oct 26, 2020
Merged

Add --ansi option #16

merged 3 commits into from
Oct 26, 2020

Conversation

Lilja
Copy link
Contributor

@Lilja Lilja commented Oct 18, 2020

No description provided.

@Lilja
Copy link
Contributor Author

Lilja commented Oct 24, 2020

@dahlia Could you please take a look at this? 😃

dahlia
dahlia reviewed Oct 25, 2020
View reviewed changes
Copy link
Owner

@dahlia dahlia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late response. Could you write the docs & changelog for this new option (in README.rst). Take a look into #1 as an example to write docs & changelog for a patch.

Thank you for the contribution!

@dahlia dahlia mentioned this pull request Oct 25, 2020
Closed
@Lilja Lilja requested a review from dahlia October 25, 2020 21:29
@dahlia dahlia merged commit d030d71 into dahlia:master Oct 26, 2020
@dahlia
Copy link
Owner

dahlia commented Oct 26, 2020

Thanks! 🙏🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dahlia dahlia dahlia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Lilja @dahlia