-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fully integrate DrawingWand C-API #194
Conversation
- Created PointInfo struct reference in API type casting. - Assigned / mapped arguments for Draw(bezier|poly(gon|line)) library method. - Completed initial unit test & documentation.
… (e.g. polygons with holes)
- Arc - Circle - Ellipse - Point Light refactoring of docs & method signature order.
…ble are likely to change. - Drawing.path_close - Drawing.path_curve - Drawing.path_curve_to_quadratic_bezier - Drawing.path_elliptic_arc - Drawing.path_finish - Drawing.path_line - Drawing.path_horizontal_line - Drawing.path_vertical_line - Drawing.path_move - Drawing.path_start
- Fill & stroke properties - Color & Matte - Basic coordinate skew & translation
- Drawing wand Push/Pop - Pattern Push/Pop (needs testing) - Clip path Push/Pop (needs testing) - Definitions Push/Pop (needs testing)
- Drawing.font_family - Drawing.font_stretch - Drawing.font_style - Drawing.font_weight
… cleaned Drawing.comment test case, and other minor code-style.
1 similar comment
WOW. I am amazed and really appreciate your effort! Although it doesn’t seem possible to be reviewed at a time, I will gradually review the whole of this patch until this weekend. Really thanks for you again. |
1 similar comment
Thanks @dahlia. With all the methods covered, I'm planing on updating the documentation + examples over the next couple weeks. |
2 similar comments
2 similar comments
…ods. - Drawing.clip_path - Drawing.font - Drawing.font_family - Drawing.stroke_dash_array - Drawing.text_encoding - Drawing.vector_graphics
Commit ee5aeb4 fixes memory leaks in the wand library. MagickWand is expecting calling programs to handle deallocation for the following methods (and wand counterparts.)
|
1 similar comment
It seems complete for me. @emcconville Is it ready to merge? |
Yes, Please merge. I believe I've covered everything in CONTRIBUTING doc. Cheers, 🍻 |
Fully integrate DrawingWand C-API
This patch was shipped with 0.4.0 release (what’s new in 0.4, changelog). Check it up! |
Originally a PU for adding a few methods I needed for whatever project, this
drawing_pu
turned into a general effort to integrate all ImageMagick's drawing wand methods. This request is open for code-review, feedback, and improved documents.Drawing API Integration Status
Original PU Overview
Examples
Drawing.polygon
Drawing.polyline
Drawing.bezier