exhaustively search for libraries in magick_home before calling find_… #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 4fe2c6b on acmanderson:master into ** on dahlia:master**. |
dahlia
approved these changes
Mar 6, 2017
|
I just deployed this version to a Heroku app using the https://github.com/ello/heroku-buildpack-imagemagick.git buildpack. It fixed my problem. Thank you for the fix and I'm looking forward to see this in Wand 0.4.5. |
|
👍 @dahlia you should consider merging this. |
|
Thanks :) |
emcconville
added a commit
that referenced
this pull request
Aug 30, 2019
emcconville
added a commit
that referenced
this pull request
Sep 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…library. Previously this would only search for the first suffix (e.g. just
libMagickWand.so) inMAGICK_HOMEbefore resorting tofind_libraryfor the same suffix. For example, iflibMagickWand-6.Q16.sowas inmagick_homebutlibMagickWand.soexisted on the library path (e.g. if you compiled ImageMagick from source but had a different version already installed on your machine), it would not load the version of the library inmagick_home. From what I could tell it didn't seem like there's a good way to write a test for this, but if there is I will add one.