Add web build & deploy #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hold on a sec |
|
lagggggggggg
ᐧ
…On Tue, May 26, 2020 at 10:47 AM bleonard252 ***@***.***> wrote:
Hold on a sec
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#34 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEOTEHHL6MA45WHJK7USZ6TRTP6DVANCNFSM4NKZJDVA>
.
|
In the end it'll be https://dahlia-os.github.io/pangolin-desktop
flutter build web doesn't support that, apparently
bet it'll break
|
I did some Git trickery in the command line and reduced the changes from 40-something (I must've done something weird with rebasing?) to the 7 you now see. |
|
Should I go ahead and merge it? |
|
Merging at the approval in #github by nmcain |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will implement a CI system for web demos. AFAIK you have to be on Chrome and a somewhat fast device to use it. I don't know, it's just the way Flutter's set up for some reason.