Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable require_trailing_commas lint rule #2

Merged
merged 1 commit into from
Jan 2, 2022

Conversation

apgapg
Copy link
Contributor

@apgapg apgapg commented Jan 2, 2022

This rule helps in prompting trailing commas thereby improving readability of code

Signed-off-by: Ayush P Gupta ayushpguptaapg@gmail.com

Description

This PR aims at enabling require_trailing_commas lint rule to improve readability of code by adding trailing commas as per Docs

Fixes #(issue)

Screenshots (if appropriate):

Type of change

Linter related change

Please tick the relevant option by putting an X inside the bracket

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • All current GitHub actions pass
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have read the CONTRIBUTING document

This rule helps in prompting trailing commas thereby improving readability of code

Signed-off-by: Ayush P Gupta <ayushpguptaapg@gmail.com>
@SincerelyFaust
Copy link
Member

Thank you a lot for this PR, I agree with this change so I've replaced the Flutter Lints package with the Lint package which follows the Effective Dart: Style Guide in the dev branch, the require_trailing_commas rule is turned on by default.
I will merge this PR but keep in mind that I'm planning on replacing the contents in the main branch with the ones in dev branch soon so if you're looking to collaborate, please send any PRs to the dev branch for now.
Have a nice day and thanks again!

@SincerelyFaust SincerelyFaust merged commit 04bbdb2 into dahliaOS:main Jan 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants