fix: black holes and worm holes do not affect zones, beams and electric explosions #961 #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czenker
commented
Oct 6, 2020
| @@ -65,6 +65,10 @@ void BlackHole::collide(Collisionable* target, float collision_force) | |||
| if (update_delta == 0.0) | |||
| return; | |||
|
|
|||
| P<SpaceObject> obj = P<Collisionable>(target); | |||
There was a problem hiding this comment.
@daid As far as I know all Collisionables inside EE are also SpaceObjects, right?
There was a problem hiding this comment.
Yes, but still, checking is good practice and very cheap.
There was a problem hiding this comment.
I'm always checking. 😆
I was asking, because with returning early any non-spaceObject Collisionable would not be moved as before. I could have made this clearer in the question.
There was a problem hiding this comment.
If it is a spaceobject, we do not really care about it now, as no wait to check if it has weight :)
olivier-vm
pushed a commit
to olivier-vm/EmptyEpsilon-Clones
that referenced
this pull request
Aug 30, 2021
fix: black holes and worm holes do not affect zones, beams and electric explosions daid#961
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #961