Fix crash in SSLabel dealloc when there are no registered observers.

The dealloc method attempts to remove the observers added in the initWithFrame method but if the initWithFrame has not been called such as when using a SSLabel in a view without a parent in a XIB then it crashes with an exception but it is not allowed to remove an observer than hasn't been added. This fix does a simple check to see if there are any registered observers before attempting to remove them.
daikini · Feb 18, 2011 · cabe99f · cabe99f · soffes · Mar 3, 2011
1 parent a134469
commit cabe99f
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/SSToolkit/SSLabel.m b/SSToolkit/SSLabel.m
@@ -16,8 +16,10 @@ @implementation SSLabel
 #pragma mark NSObject
 
 - (void)dealloc {
-	[self removeObserver:self forKeyPath:@"verticalTextAlignment"];
-	[self removeObserver:self forKeyPath:@"textEdgeInsets"];
+    if ([self observationInfo] != nil) {
+        [self removeObserver:self forKeyPath:@"verticalTextAlignment"];
+        [self removeObserver:self forKeyPath:@"textEdgeInsets"];
+    }
 	[super dealloc];
 }