Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace onChange with onBlur to set squad handle when focusing on next field #2196

Merged
merged 1 commit into from
Sep 19, 2023
Merged

fix: replace onChange with onBlur to set squad handle when focusing on next field #2196

merged 1 commit into from
Sep 19, 2023

Conversation

omBratteng
Copy link
Contributor

Changes

Describe what this PR does

  • fix: replace onChange with onBlur to set squad handle when focusing on next field

Events

N/A

Please make sure existing components are not breaking/affected by this PR

Manual Testing

On those affected packages:

  • Have you done sanity checks in the webapp?
  • Have you done sanity checks in the extension?
  • Does this not break anything in companion?

Did you test the modified components media queries?

  • MobileL (420px)
  • Tablet (656px)
  • Laptop (1020px)

Did you test on actual mobile devices?

  • iOS (Chrome and Safari)
  • Android

WT-1861 #done

@rebelchris rebelchris requested a review from a team September 19, 2023 10:26
@omBratteng omBratteng merged commit 3719c29 into WT-1778-move-to-react Sep 19, 2023
3 of 4 checks passed
@omBratteng omBratteng deleted the WT-1861 branch September 19, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebelchris rebelchris rebelchris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@omBratteng @rebelchris