Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🧩 FEATURE REQUEST: Match browser color theme #279

Closed
omothm opened this issue May 6, 2021 · 4 comments · Fixed by dailydotdev/apps#591
Closed

🧩 FEATURE REQUEST: Match browser color theme #279

omothm opened this issue May 6, 2021 · 4 comments · Fixed by dailydotdev/apps#591
Assignees
@Mahdhir
Labels
help wanted Status: Completed Type: Feature

Comments

@omothm
Copy link

omothm commented May 6, 2021

Feature Request

Description

I would like to have the option to set the color theme to match the browser's (or maybe the system's) color theme. When the browser changes to a light theme, the new tab page changes to a light theme. When the browser changes to a dark theme, the new tab page follows as well.

Solution

Instead of the "Light Theme" switch under Preferences, a dropdown with these 3 options is recommended:

  • Light Theme
  • Dark Theme
  • Match Browser Theme

Alternate Solutions

N/A
@omothm omothm changed the title 🧩 FEATURE REQUEST: Match browsercolor theme 🧩 FEATURE REQUEST: Match browser color theme May 6, 2021
@idoshamun
Copy link
Member

Hey @omothm,

Thanks for this great suggestion.
We will consider it in our next product planning meeting :)

@idoshamun
Copy link
Member

Following our last product planning, we have designed a solution for this issue, and we're willing to open it for contribution.

It should look like this, where the new "Auto" setting should match the browser theme.
feature design

How to get started?

Sketch Cloud project is available here with all the nitty-gritty 👇
https://www.sketch.com/s/2549ccf9-b98c-413f-96fb-81b05b59e65f/a/ygwyyeq

@Mahdhir
Copy link

Mahdhir commented Jun 24, 2021

I can look into this if this is still available 😄

@idoshamun
Copy link
Member

@Mahdhir yes, please! 🤩

@Mahdhir Mahdhir mentioned this issue Jun 27, 2021
Merged
idoshamun pushed a commit to dailydotdev/apps that referenced this issue Jul 11, 2021
@Mahdhir
feat: add browser theme based 'auto' mode for theme settings (#591)
5df6e86 
Add feature to set light/dark mode based on the browser preferences. 
Also checks whether the browser supports the feature before adding the new option.

Closes dailydotdev/daily#279
sshanzel pushed a commit to sshanzel/dailydev-apps that referenced this issue Jul 18, 2021
@Mahdhir @sshanzel
feat: add browser theme based 'auto' mode for theme settings (dailydo…
e884951 
…tdev#591)

Add feature to set light/dark mode based on the browser preferences. 
Also checks whether the browser supports the feature before adding the new option.

Closes dailydotdev/daily#279
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mahdhir Mahdhir

Labels
help wanted Status: Completed Type: Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature: Added OS theme based 'auto' mode for theme settings Mahdhir/apps
3 participants
@idoshamun @Mahdhir @omothm