Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: send, cleaner useSendAsync, note > payment link #180

Merged
merged 2 commits into from
Aug 21, 2023

Conversation

dcposch
Copy link
Member

@dcposch dcposch commented Aug 21, 2023

fixes #77

  • note > link
  • explain what a Payment Link is. subtitle “This will create a link that can be redeemed by anyone with a Daimo account or an Ethereum wallet”

@@ -59,17 +59,17 @@ export function useWarmCache(enclaveKeyName?: string, address?: Address) {
const accountCache: Map<string, Promise<DaimoAccount>> = new Map();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Map<Address, ...>

@dcposch
Copy link
Member Author

dcposch commented Aug 21, 2023

Clean up SendScreen, useSendAsync

fixes #68

add Payment Link explanation

image

@dcposch dcposch changed the title fix: accountCache key, note > payment link fix: send, cleaner useSendAsync, note > payment link Aug 21, 2023
@dcposch dcposch merged commit 2d7d9e4 into master Aug 21, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Note clarity
2 participants