improve usage code #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
dcposch
reviewed
Oct 3, 2023
test/Verify.t.sol
Outdated
| contract VerifyTest is Test { | ||
| uint256[2] public pubKey; | ||
|
|
||
| function setUp() public { |
There was a problem hiding this comment.
recommend CREATE2-deploying P256Verifier in setUp()
two advantages:
- test reliability: tests run offline, dont rely on
fork-url/ the public base-goerli endpoint flakes sometimes - sanity checks that the hardcoded
VERIFIERaddress and create2-deployedP256Verifieraddress match
There was a problem hiding this comment.
seems running CREATE2 in tests generates a different address. Worth investigating in more detail but I suspect it's a Foundry bug as we discussed. Maybe we should just pull this out into its own issue for future?
re public base-goerli endpoint flakes: I've been using a different RPC (locally and in this PR) which hasn't flaked for me since I switched
There was a problem hiding this comment.
Moved to #22. Merging as-is.
dcposch
reviewed
Oct 3, 2023
nalinbhardwaj
force-pushed
the
nibnalin/Verifysol
branch
from
0f661cd
to
6674f37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.