Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🇰🇷 Advanced Korean Translation - III Applications #244

Merged
merged 19 commits into from Aug 9, 2023

Conversation

11mLLM
Copy link
Contributor

@11mLLM 11mLLM commented Jul 28, 2023

✱ Improve all that jazz about translation

Dear @omarsar,
please assign those who had contributed to this project.

neont21 and others added 11 commits July 23, 2023 13:49
* Add transalation for introduction on document pf kr

* Add translation for first example on document pf kr

* Add translation for multiple parameter function

* Add translation for thought

* Add translation on parameter of multiple paramter prompt

* Fix some terms to fit with Korean convention

* Fix some weird word choice in Korean

* Add translation on meta.kr for prompt function

* Update fixes to reflect feedback
Improve some Korean translation of Applications part
Add Translation of applications/coding.kr.mdx
Revert "Add New Korean translation for Techniques"
@vercel
Copy link

vercel bot commented Jul 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
prompt-engineering-guide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2023 3:34pm

@11mLLM
Copy link
Contributor Author

11mLLM commented Aug 3, 2023

Dear @omarsar

My team just finished the 2nd review.
It's time to merge into the main branch I guess.
Also please make sure to assign those who have contributed!

Thanks.

@omarsar
Copy link
Member

omarsar commented Aug 9, 2023

@11mLLM Thanks for the edits. I think this PR has some conflicts. Please address this before I can merge.

@neont21
Copy link
Contributor

neont21 commented Aug 9, 2023

I solved the conflicts.

@omarsar omarsar merged commit 0c3d283 into dair-ai:main Aug 9, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants