Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window can not be brought back from the tray when application is quit while jobs are running #125

Closed
bertfrees opened this issue Mar 16, 2023 · 8 comments
Milestone

Comments

@bertfrees
Copy link
Member

bertfrees commented Mar 16, 2023

Very similar to #96.

When the application is quit while jobs are running, the window closes and the tray stays active but the window can not be brought back from the tray (all items grey). Only by relaunching the application you can bring the window back, in which case the "Some jobs are still running in the engine" warning will appear.

@marisademeglio
Copy link
Member

I can't reproduce this. When I start a big job and quit the application midway through execution, the engine keeps running but the application and tray both exit. And when I restart the app, it starts a new instance of the engine.

Can you give me a step by step recipe?

@bertfrees
Copy link
Member Author

Well you could not reproduce #96 either, so maybe logical that you can't reproduce this one. But I'll add the steps...

@bertfrees
Copy link
Member Author

bertfrees commented Mar 16, 2023

Steps to reproduce:

  • Start application
  • Select script: DAISY 2.02 Validator
  • Fill in NCC field
  • Run
  • Quit application, e.g. with ⌘Q

All items in tray menu gray.

  • Start application again
  • See the "Some jobs are still running" warning appear

@marisademeglio
Copy link
Member

So with ⌘H, you're hiding the window, but I wouldn't say it's the same as quitting the application (⌘Q).

But still I get different results than you. The tray menu is not ever grayed out again.

Whether I re-enter the application from the mac dock or use the /Applications shortcut, I get a window for the job that's still in progress.

When I try to say Tray->Open Window, nothing happens. But I think that's a different behavior entirely.

@bertfrees
Copy link
Member Author

Sorry! I meant ⌘Q.

@marisademeglio
Copy link
Member

Ok! Yet still no luck reproducing, my earlier comment still applies.

@NPavie
Copy link
Collaborator

NPavie commented Mar 17, 2023

I tried to reproduced the issue :

I'll look into it

@NPavie
Copy link
Collaborator

NPavie commented Mar 17, 2023

Ok I think I found out how to fix that.
It is indeed like for #96 (just a different dialog).
I'll fix this behaviour when the window is opened, but in case of quitting the app from the tray with the window already closed, there is no way to change this particular behaviour.

(I think it is macOS default behaviour to block interactions on a app when a dialog not bound to a window is raised, to ensure user does not miss critical inputs)

I'm not sure on why you don't have the dialog displayed every time though, but it might have been placed in a specific workspace.

@NPavie NPavie closed this as completed in 59bb4ae Mar 17, 2023
@marisademeglio marisademeglio added this to the 1.0.0 milestone Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants