Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize MPNCOV.py for less memory usage and faster inference #29

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Optimize MPNCOV.py for less memory usage and faster inference #29

wants to merge 2 commits into from

Conversation

csmliu
Copy link

@csmliu csmliu commented Feb 26, 2020

I am going to compare your method in my paper, and am now generating your results using the released model.
According to #22, I modified the code for a faster inference and less memory usage. Kindly have a check.

Since I_hat is not a three-dimensioni tensor now, the bmm in the backward function should be replaced by @ as well
@aryan-f
Copy link

aryan-f commented Sep 11, 2020

Could not train the model after this modification. Torch 0.4 did not have a diagnol method defined for Tensors, and working around it usingtorch.diagnol(tensor) causes the loss to jump to infinity.

@ZFhuang
Copy link

ZFhuang commented Jul 4, 2021

Nice commit, saves a lot of memory.

@antonelse
Copy link

the problem still exist ! Does anyone knows where is the problem ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants