Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot run GCI with -s localmodule flag #193

Closed
F0rzend opened this issue Mar 3, 2024 · 6 comments
Closed

Cannot run GCI with -s localmodule flag #193

F0rzend opened this issue Mar 3, 2024 · 6 comments
Labels
help wanted Extra attention is needed

Comments

@F0rzend
Copy link

F0rzend commented Mar 3, 2024

What version of GCI are you using?

v0.13.0

Reproduce Steps

I run from root of my project with relative path to the file:
image

What did you expect to see?

Successfully formatted file

What did you see instead?

Error: error reading local packages: [-: no Go files in ]

@daixiang0 daixiang0 added the help wanted Extra attention is needed label Mar 4, 2024
@daixiang0
Copy link
Owner

@F0rzend could you share a case as simple as possible to reproduce it?

@CarlosRDomin
Copy link

Same here 😭
I'll try to share a minimum reproducible example tomorrow if @F0rzend doesn't beat me to it :)

@petr-korobeinikov
Copy link
Contributor

👋

#192 should solve problem above.

@petr-korobeinikov
Copy link
Contributor

Looking forward to see a minimal example...

@matthewhughes934
Copy link
Contributor

matthewhughes934 commented Mar 7, 2024

Has this issue been raised with golangci-lint? I ask because it might be a blocker for releasing this feature upstream and I see gci has already been updated (but not included in any release) to include the change with golangci/golangci-lint@9c492af. That is, it might be worth reverting that change if it's not certain a fix will be available in time for whenever golangci-lint plans on making their next release

EDIT: I mentioned it on the #golangci-lint slack channel

@CarlosRDomin
Copy link

Apologies, it's been a busy week. I haven't had enough time to provide a minimum reproducible example but I can confirm that #192 fixes the problems with my repo and everything works as expected!! Thank you so much @petr-korobeinikov for your great work, also the new tests look great :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants