Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): downgrade github.com/daixiang0/gci from 0.13.0 to 0.12.3 #4484

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

ldez
Copy link
Member

@ldez ldez commented Mar 11, 2024

This reverts commit 9c492af (#4429).

Related to daixiang0/gci#193

@ldez ldez added dependencies Relates to an upstream dependency linter: update version Update version of linter go Pull requests that update Go code labels Mar 11, 2024
@ldez ldez added this to the next milestone Mar 11, 2024
@ldez ldez requested review from alexandear and removed request for alexandear March 11, 2024 18:04
@ldez ldez merged commit 5cb1656 into golangci:master Mar 11, 2024
12 checks passed
@ldez ldez deleted the fix/gci-revert branch March 11, 2024 18:57
@CarlosRDomin
Copy link

Should we bump gci to v0.13.1 now that there's a fix that works? The localmodule feature is very helpful to many of us :)
CC @ldez

@ldez
Copy link
Member Author

ldez commented Mar 13, 2024

The updates are handled by dependabot every Sunday.

FYI, based on what I see inside the implementation of v0.13.1, I think the implementation will not work as expected inside golangci-lint.

I know how to get go.mod file in the right way, I created gomoddirectives and modinfo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Relates to an upstream dependency go Pull requests that update Go code linter: update version Update version of linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants