Prefer project-root in favor of project-roots (#105) #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dajva
requested changes
Jan 29, 2023
rg.el
Outdated
| ((fboundp 'project-root) | ||
| (project-root project)) | ||
| ((fboundp 'project-roots) | ||
| (car (project-roots) project))))) |
There was a problem hiding this comment.
Seems ending parenthesis is at the wrong place. Should be (car (project-roots project)), I believe.
There was a problem hiding this comment.
Ouch, sorry. I clearly never tested this code path.
Fixed.
The latter has been deprecated. If project-root is not bound, use project-roots like before.
jobor
force-pushed
the
prefer-project-root
branch
from
bf0d4ed
to
aca92ec
Compare
dajva
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latter has been deprecated.
If project-root is not bound, use project-roots like before.