Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer project-root to project-roots #105

Closed
manuel-uberti opened this issue Oct 19, 2020 · 3 comments
Closed

Prefer project-root to project-roots #105

manuel-uberti opened this issue Oct 19, 2020 · 3 comments

Comments

@manuel-uberti
Copy link

Hi,

first of all thanks for this great package.

May I suggest to use project-root instead of project-roots in rg-project-root? project-roots is deprecated.

Thank you!

@dajva
Copy link
Owner

dajva commented Oct 19, 2020

Thanks for the kind words and the suggestion.

This change is too new to get from emacs internally since this package supports emacs-25.1.
It's possible to have it as a requirement of course and get a newer version from elpa but since the project system used is optional I don't really want to depend on any of them explicitly.

I'll keep this open and see what to do. Maybe just check if project-root is available and us it if it is.

@manuel-uberti
Copy link
Author

Totally understand your point. Feel free to close this whenever you like.

@hmelman
Copy link

hmelman commented Apr 19, 2022

Maybe just check if project-root is available and us it if it is.

Now that Emacs 28 is out, perhaps its time to do this.

jobor added a commit to jobor/rg.el that referenced this issue Jan 16, 2023
The latter has been deprecated.

If project-root is not bound, use project-roots like before.
jobor added a commit to jobor/rg.el that referenced this issue Feb 1, 2023
The latter has been deprecated.

If project-root is not bound, use project-roots like before.
dajva pushed a commit that referenced this issue Feb 1, 2023
The latter has been deprecated.

If project-root is not bound, use project-roots like before.
@dajva dajva closed this as completed Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants