Fix for Java 1.6 and 1.7 #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change dakrone#99 introduced a Java class which is compiled ahead of time to the JAR. By default the Java classes are built for use in current Java version and to allow use in older Java versions an option has to be provided.
|
Merged, thanks! I'll cut a new release |
|
Released 5.6.1 with this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change #99 introduced a Java class which is compiled ahead of time to
the JAR. By default the Java classes are built for use in current Java
version and to allow use in older Java versions an option has to be
provided.
Currently Cheshire is built on Java 1.8 and doesn't work at Java 1.6 or 1.7. This was noticed when Cheshire dependency on Ring-middleware-format was bumped to the latest version: https://travis-ci.org/ngrunwald/ring-middleware-format/jobs/122605740