Migrate CI to Github Actions #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymndhng
changed the title
added 4 commits
July 28, 2020 22:21
The certificates in keystore & client-keystore no longer work under Java 11. I regenerated the keystores using these commands and the tests now pass, which are roughly: Step 1: Create server keystore with private key keytool -genkeypair -keyalg RSA -keysize 2048 -alias server -dname "CN=Hakan,OU=Amsterdam,O=Thunderberry,C=NL" -ext "SAN:c=DNS:localhost,IP:127.0.0.1" -validity 3650 -keystore keystore -storepass keykey -keypass keykey Step 2: Export server certificate keytool -exportcert -keystore keystore -storepass keykey -alias server -rfc -file server.cer Step 3: Create client keystore and import server certificate keytool -importcert -keystore client-keystore -file server.cer -alias server-storepass keykey Step 4: Create client private key and store in client-keystore keytool -genkeypair -keystore client-keystore -keyalg RSA -keysize 2048 -alias client -dname "CN=Suleyman,OU=Altindag,O=Altindag,C=NL" -validity 3650 -storepass keykey -keypass keykey Step 5: Export client certificate keytool -exportcert -keystore client-keystore -storepass keykey -alias client-rfc -file client.cer Step 6: Import client certificate into server keystore keytool -keystore keystore -importcert -file client.cer -alias client -storepass keykey commit b8e6428 Author: Raymond Huang <rymndhng@gmail.com> Date: Tue Aug 6 22:23:57 2019 -0700 Run :all tests with travisci
rymndhng
force-pushed
the
migrate-to-github-actions
branch
from
1b7a3eb
to
4c04d70
Compare
Yep! I just rebased this branch off of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation for moving to Github Actions is to be able to run the integration suite.
Improvements
Additionally, to get the :integration test suite passing, the following changes were required:
keystoreandclient-keystoreto work on Java >= 11Additional Notes
Commands to recreate the
keystore&client-keystoreto test Mutual TLS: