Feature/bmw 3 additional data #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalathegreat
requested changes
Apr 9, 2024
dalathegreat
approved these changes
Apr 9, 2024
dalathegreat
reviewed
Apr 9, 2024
| @@ -306,6 +348,12 @@ static uint16_t battery_prediction_voltage_longterm_charge = 0; | |||
| static uint16_t battery_prediction_voltage_longterm_discharge = 0; | |||
| static uint16_t battery_prediction_duration_charging_minutes = 0; | |||
| static uint16_t battery_target_voltage_in_CV_mode = 0; | |||
|
|
|||
| uint16_t battery_soc = 0; | |||
There was a problem hiding this comment.
consider making these static so no other battery tries to use the same name and get conflicts! battery_soc is quite generic :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Additional data fetch from battery. Found additional method to fetch data that was not available before.
Why
Having min/max/avg cell voltage and SOH is needed to know the state and health of the battery.
How
Sending specific CAN messages makes it respond a little later with requested information.