Bugfix: P3196 on ZE0 #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
User testing showed promising results without error codes! Merging this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR attempts to further reduce the amount of active error messages on battery upgraded 2010-2012 ZE0s.
Why
To not have users worry, and make all modules work as inteded
How
This P3196 code is reported from the battery. The manual states that "When no CAN communication signal is received from on-board charger continuously. So the AZE0/ZE1 battery no longer sees the OBC (PDM).
On the ZE0, the OBC sends the following messages;
0x5bf
0x380
On the AZE0 (and ZE1), the PDM sends the following messages
0x393
0x390
This PR adds 393 and 390 sending towards the battery
Testers wanted! Binaries attached:
3-port:can-bridge-firmware_v4.25beta.zip
2-port:canbridge_4.25beta.zip
NEWER:
2-port: canbridge_4.25beta2.zip
3-port: can-bridge-firmware_v4.25beta2.zip