Skip to content

Commit

Permalink
Issue #136: method validation is incorrect as well (DUH) back it out …
Browse files Browse the repository at this point in the history
  • Loading branch information
dalehenrich committed Jan 31, 2015
1 parent 34f25b2 commit 78a6033
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 17 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ validateExtensionMethodCategory: categoryName for: className selector: selector
"extracted from PackageInfo>>isForeignClassExtension:"

| prefix prefixSize catSize |
true
ifTrue: [
"https://github.com/GsDevKit/gsDevKitHome/issues/53: faulty filetree package validation logic"
^ self ].
prefix := '*' , self packageNameFromPackageDirectory asLowercase.
categoryName
ifNotNil: [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,5 @@
"methodSelectorFor:" : "ChristopheDemarey 5/31/2013 23:28",
"packageNameFromPackageDirectory" : "dkh 8/10/2012 14:55",
"validateClassCategory:for:" : "dkh 01/31/2015 12:20",
"validateExtensionMethodCategory:for:selector:" : "dkh 01/31/2015 08:24",
"validateExtensionMethodCategory:for:selector:" : "dkh 01/31/2015 12:48",
"verifyCategory:matches:" : "dkh 01/31/2015 07:05" } }

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ tests
expectedFailures
"https://github.com/GsDevKit/gsDevKitHome/issues/53: faulty filetree package validation logic"

^ #(#'testClassError')
^ #(#'testClassError' #'testExtensionMethodError')
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"class" : {
},
"instance" : {
"expectedFailures" : "dkh 01/31/2015 12:21",
"expectedFailures" : "dkh 01/31/2015 12:48",
"tearDown" : "dkh 01/31/2015 12:29",
"tearDownPackagesList" : "dkh 01/31/2015 07:31",
"testClassError" : "dkh 01/31/2015 07:46",
Expand Down

Large diffs are not rendered by default.

0 comments on commit 78a6033

Please sign in to comment.