Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

category property for class and package membership can become out of sync #136

Closed
dalehenrich opened this issue Jan 31, 2015 · 1 comment
Closed

category property for class and package membership can become out of sync #136

dalehenrich opened this issue Jan 31, 2015 · 1 comment
Labels
in process

Comments

@dalehenrich
Copy link
Owner

While doing a merge for a "renamed" package, I made the mistake of moving a class properties file (with the category set to the old package name) into the new package and when filetree creates the class in the other category, the class is effectively moved to a different package ... since the category pretty much needs to stay in sync with the package, I think an error should be thrown if a class is loaded whose category is not consistent with the package that the class resides within ...
@dalehenrich
Copy link
Owner Author

extension method categories also need to conform...

dalehenrich added a commit that referenced this issue Jan 31, 2015
@dalehenrich
Issue #136: bugfix plus tests. throw error when class cateogyr or met…
56d6e56 
…hod category are not consistent with the package name
dalehenrich added a commit that referenced this issue Jan 31, 2015
@dalehenrich
Issue #136: patch needed for GemStone 3.1.0.6
6bce0f2
dalehenrich added a commit that referenced this issue Jan 31, 2015
@dalehenrich
Issue #136: fix test case
e7cfeee
dalehenrich added a commit that referenced this issue Jan 31, 2015
@dalehenrich
Merge pull request #137 from dalehenrich/issue_136
7930385 
fix for Issue #136
dalehenrich added a commit that referenced this issue Jan 31, 2015
@dalehenrich
Merge pull request #137 from dalehenrich/issue_136
5b7f4eb 
fix for Issue #136
Conflicts:

	repository/MonticelloFileTree-Core.package/MCFileTreeStCypressReader.class/instance/addClassDefinitionFrom.comment..st
	repository/MonticelloFileTree-Core.package/MCFileTreeStCypressReader.class/instance/addExtensionClassAndMethodDefinitionsFromEntry..st
	repository/MonticelloFileTree-Core.package/MCFileTreeStCypressReader.class/instance/addMethodDefinitionsForClass.methodProperties.in..st
dalehenrich added a commit that referenced this issue Jan 31, 2015
@dalehenrich
Issue #136: logging for test failure
7e28544
dalehenrich added a commit that referenced this issue Jan 31, 2015
@dalehenrich
Issue #136: pharo1.1 portability changes ... plus class error logging
25e466f
dalehenrich added a commit that referenced this issue Jan 31, 2015
@dalehenrich
Issue #136: back out the class category validation, due to faulty val…
a5103be 
…idation logic (GsDevKit/gsDevKitHome#53)
dalehenrich added a commit that referenced this issue Jan 31, 2015
@dalehenrich
Issue #136: cherrypick the pharo1.1_dev changes
a3b517f
dalehenrich added a commit that referenced this issue Jan 31, 2015
@dalehenrich
Issue #136: method validation is incorrect as well (DUH) back it out …
78a6033 
…for GsDevKit/gsDevKitHome#53:
dalehenrich added a commit that referenced this issue Jan 31, 2015
@dalehenrich
Issue #136: additional MCFileTreeIssue136Test>>tearDown logic needed …
71349fd 
…for failed method test
@dalehenrich dalehenrich mentioned this issue Jan 31, 2015
Closed
dalehenrich added a commit that referenced this issue Jan 31, 2015
@dalehenrich
Issue #136: chasing random MCFileTreeIssue97Test>>testLoad failures
ab5eece
dalehenrich added a commit that referenced this issue Jan 31, 2015
@dalehenrich
Issue #136: heavy duty logging called for ...
83a06a6
dalehenrich added a commit that referenced this issue Jan 31, 2015
@dalehenrich
Issue #136: from logging it appears that the package Issue97 is left …
4258ab9 
…lying around ...
dalehenrich added a commit that referenced this issue Jan 31, 2015
@dalehenrich
Issue #136: fix logging
793573e
dalehenrich added a commit that referenced this issue Jan 31, 2015
@dalehenrich
Issue #136: cherry pick code from gemstone2.4 branch
ecfa46e
dalehenrich added a commit that referenced this issue Jan 31, 2015
@dalehenrich
Issue #136: cherry pick code from gemstone2.4 branch :: completely di…
a108428 
…sable validation due to GsDevKit/gsDevKitHome#53

Conflicts:

	repository/MonticelloFileTree-Tests.package/MCFileTreeIssue136Test.class/instance/expectedFailures.st
	repository/MonticelloFileTree-Tests.package/MCFileTreeIssue136Test.class/instance/tearDown.st
dalehenrich added a commit that referenced this issue Jan 31, 2015
@dalehenrich
Issue #136: fix for issue causing GsDevKit/gsDevKitHome#53 and add tests
b224f8b
@dalehenrich dalehenrich mentioned this issue Feb 1, 2015
Merged
dalehenrich added a commit that referenced this issue Feb 1, 2015
@dalehenrich
Merge branch 'gemstone2.4_dev' into gemstone2.4 :: final fix for Issue …
21a1093 
…#136

Conflicts:
	repository/MonticelloFileTree-Tests.package/MCFileTreeIssue136Test.class/instance/expectedFailures.st
	repository/MonticelloFileTree-Tests.package/MCFileTreeIssue136Test.class/instance/tearDownPackagesList.st

Conflicts:

	repository/MonticelloFileTree-Tests.package/MCFileTreeIssue97Test.class/instance/testLoad.st
dalehenrich added a commit that referenced this issue Feb 1, 2015
@dalehenrich
Merge branch 'master' into pharo1.1_dev :: Issue #136 bugfix
3980a1a 
Conflicts:
	repository/MonticelloFileTree-Tests.package/MCFileTreeIssue136Test.class/instance/testClassError.st
	repository/MonticelloFileTree-Tests.package/MCFileTreeIssue136Test.class/instance/testExtensionMethodError.st
dalehenrich added a commit that referenced this issue Feb 1, 2015
@dalehenrich
Merge branch 'master' into pharo1.4_dev :: Issue #136 bugfix
3b0ba2d
dalehenrich added a commit that referenced this issue Feb 1, 2015
@dalehenrich
Merge branch 'master' into pharo2.0_dev :: Issue #136 bugfix
c374719
dalehenrich added a commit that referenced this issue Feb 1, 2015
@dalehenrich
Merge branch 'master' into pharo3.0_dev :: Issue #136 bugfix
9ec268a
dalehenrich added a commit that referenced this issue Feb 1, 2015
@dalehenrich
Merge branch 'master' into squeak4.3_dev :: Issue #136 bugfix
7bf8d4f
@dalehenrich dalehenrich mentioned this issue Feb 1, 2015
Closed
@dalehenrich dalehenrich mentioned this issue Feb 1, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in process
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dalehenrich