Skip to content

Commit

Permalink
3.4.0 is when I want to start using the GCI call ... although at the …
Browse files Browse the repository at this point in the history
…moment it looks like there is a bug in the gci call, as GsProcess>>_topazStepOverInFrame: (used by topaz) provides the expected behavior ... as early as 3.2.0 perhaps
  • Loading branch information
dalehenrich committed Dec 22, 2016
1 parent 381545c commit 2fc88f1
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 11 deletions.
Original file line number Diff line number Diff line change
@@ -1,23 +1,19 @@
menu actions
dbStepThruMenuAction: listElement selectionIndex: selectionIndex
(self topez effectiveApiVersion < '1.4.0' asMetacelloVersionNumber
or: [
(System stoneVersionReport at: 'gsVersion') asMetacelloVersionNumber
<= '3.4.0' asMetacelloVersionNumber ])
or: [ (System stoneVersionReport at: 'gsVersion') asMetacelloVersionNumber
< '3.4.0' asMetacelloVersionNumber ])
ifTrue: [ self dbSetThruBreaksDuring: [ self dbStep: #'over' ] ]
ifFalse: [
| level processOop stack transcriptProxy |
ifFalse: [ | level processOop stack transcriptProxy |
stack := self theStack.
processOop := self processOop.
level := stack currentFrame frameIndex.
self topez disableSessionMethods.
transcriptProxy := TranscriptProxy proxyTranscript.
[
TranscriptProxy registerTranscriptClientForwarder: nil.
[ TranscriptProxy registerTranscriptClientForwarder: nil.
processResult := self topez topezClientForwarder
perform: #'dbStep:forProcessOop:'
withArguments:
{level.
withArguments: {level.
processOop} ]
ensure: [ TranscriptProxy registerTranscriptClientForwarder: transcriptProxy ].
processTerminated := (self debugExceptionSymbols includes: processResult)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"dbStep:" : "dkh 09/10/2016 10:26",
"dbStepIntoMenuAction:selectionIndex:" : "dkh 01/07/2014 07:50",
"dbStepOverMenuAction:selectionIndex:" : "dkh 01/07/2014 07:32",
"dbStepThruMenuAction:selectionIndex:" : "dkh 12/21/2016 14:48",
"dbStepThruMenuAction:selectionIndex:" : "dkh 12/21/2016 16:10",
"dbStoreInObjectLog" : "MarianoMartinezPeck 11/12/2015 12:58",
"dbStoreInObjectLogMenuAction:selectionIndex:" : "MarianoMartinezPeck 11/12/2015 12:54",
"dbUpMenuAction:selectionIndex:" : "dkh 01/07/2014 07:54",
Expand Down

Large diffs are not rendered by default.

0 comments on commit 2fc88f1

Please sign in to comment.