Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand lints #530

Merged
merged 3 commits into from
Aug 28, 2023
Merged

Expand lints #530

merged 3 commits into from
Aug 28, 2023

Commits on Aug 27, 2023

  1. Expand lints

    Adds a lints section to the top of lib.rs with the following:
    
        #![warn(
            clippy::unwrap_used,
            missing_docs,
            rust_2018_idioms,
            unused_lifetimes,
            unused_qualifications
        )]
    
    `warn` is used instead of `deny` to prevent the lints from firing during
    local development, however we already configure `-D warnings` in CI so
    if any lint fails on checked-in code, it will cause a CI failure.
    
    This commit also fixes or explicitly allows any current violations of
    these lints. The main ones were:
    
    - `clippy::unwrap_used`: replaces usages of `unwrap` with `expect`
    - `rust_2018_idioms`: no implicit lifetimes, which were present on
      usages of `core::fmt::Formatter`
    tarcieri committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    68f9e73 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. Configuration menu
    Copy the full SHA
    d6b8122 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    321c2f8 View commit details
    Browse the repository at this point in the history