Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add group ops #8

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add group ops #8

wants to merge 5 commits into from

Conversation

cathieyun
Copy link
Member

@cathieyun cathieyun commented Apr 9, 2019

Added skeleton for group ops.

TODO (next PR?):

  • actually get the right value for EDWARDS_D (waiting on field arithmetic code to be implemented)

@cathieyun cathieyun marked this pull request as ready for review April 9, 2019 06:31
@hdevalence hdevalence changed the base branch from add-field-impl to master May 25, 2019 00:15
@hdevalence
Copy link
Contributor

Eventually we want to have impl From<[u8;32]> for EdwardsPoint and impl Into<[u8;32]> for EdwardsPoint (ie define a serialization format) but for the moment, to do testing, we could add a function that takes a y value and a sign and tries to solve for (x,y) using the sign parameter to distinguish between the two possible solutions (if there are any; if not we should return None). The x-recovery will probably be similar to the Ed25519 case, except that we need to check how to compute square roots of a ratio in the Doppio base field.

Alternately, we could try generating a single point in Sage and hardcoding it (and do the x-coordinate recovery later).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants