Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build fails if rand feature is disabled #108

Closed
tarcieri opened this issue Dec 11, 2019 · 2 comments
Closed

Build fails if rand feature is disabled #108

tarcieri opened this issue Dec 11, 2019 · 2 comments
Assignees
@isislovecruft
Labels
bug

Comments

@tarcieri
Copy link
Contributor

tarcieri commented Dec 11, 2019 •
edited
Loading 

   Compiling ed25519-dalek v1.0.0-pre.3
error[E0432]: unresolved import `rand`
  --> /Users/bascule/.cargo/registry/src/github.com-1ecc6299db9ec823/ed25519-dalek-1.0.0-pre.3/src/ed25519.rs:14:5
   |
14 | use rand::{CryptoRng, RngCore};
   |     ^^^^ use of undeclared type or module `rand`

That line needs a #[cfg(feature = "rand")] above it.
@isislovecruft
Copy link
Member

Ah, oops, thanks @tarcieri!

isislovecruft added a commit to isislovecruft/ed25519-dalek that referenced this issue Dec 11, 2019
@isislovecruft
Fix breakage on builds with the rand crate disabled.
8a2e9af 
 * CLOSES dalek-cryptography#108
 * THANKS TO @tarcieri
@isislovecruft
Copy link
Member

Fixed in 8a2e9af

@isislovecruft isislovecruft self-assigned this Dec 11, 2019
@tarcieri tarcieri mentioned this issue Dec 11, 2019
Merged
cbeck88 added a commit to cbeck88/ed25519-dalek that referenced this issue Jan 7, 2020
@cbeck88
Further fixups for dalek-cryptography#108
ad08c9c 
The build is still broken when rand is disabled, we are building with

```
..., default-features = false, features = ["alloc", "nightly", "serde", "u64_backend"] }
```
@cbeck88 cbeck88 mentioned this issue Jan 7, 2020
Closed
@tarcieri tarcieri mentioned this issue Jun 19, 2020
Closed
cbeck88 added a commit to cbeck88/ed25519-dalek that referenced this issue Jul 4, 2020
@cbeck88
Further fixups for dalek-cryptography#108
d615588 
The build is still broken when rand is disabled, we are building with

```
..., default-features = false, features = ["alloc", "nightly", "serde", "u64_backend"] }
```
cbeck88 added a commit to cbeck88/ed25519-dalek that referenced this issue Aug 4, 2020
@cbeck88
Make use rand::... gated on cfg(feature = "rand")
bb82d61 
This is no longer actively breaking our no_std build, but I think
it's still technically a minor bug, and further case of issue dalek-cryptography#108
@cbeck88 cbeck88 mentioned this issue Aug 4, 2020
Merged
huitseeker pushed a commit to huitseeker/ed25519-dalek that referenced this issue Nov 3, 2020
@cbeck88 @huitseeker
Make use rand::... gated on cfg(feature = "rand")
e0c97c5 
This is no longer actively breaking our no_std build, but I think
it's still technically a minor bug, and further case of issue dalek-cryptography#108
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@isislovecruft isislovecruft

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tarcieri @isislovecruft