Release/v0.11.0 #92
Release/v0.11.0 #92
Conversation
I don't think it is necessary wait for this. We can do a next release as soon as we have a fully working light client instead? |
As far as I remember that's were the only necessary changes in the repo (maybe @tarcieri has sth to add). I followed the procedure described here to publish the crate (but it's been a while). |
Good point! Yeah, let's follow all the established conventions from tendermint core where it makes sense 🎉 |
|
Great I opened it for review/approval! |
CHANGES.md
Outdated
| - `subtle-encoding` from `0.3` to `0.5` ([#47]) | ||
| - `uuid` from `0.7` to `0.8` ([#91]) | ||
| - replace `rand_os` with `getrandome` ([#90]) | ||
| - pin to `ed25519-dalek` `1.0.0-pre.3` ([#83]) |
There was a problem hiding this comment.
This change was reverted by updating to signatory 0.17 (which now does the pinning for us). Do you still want to include it here? This is probably not necessary.
There was a problem hiding this comment.
Yeah, I effectively reverted that and opened an upstream issue here (which has since been fixed): dalek-cryptography/ed25519-dalek#108
There was a problem hiding this comment.
Duh thanks will remove.
There was a problem hiding this comment.
Left a few nits and suggestions.
I think after https://github.com/interchainio/tendermint-rs/pull/92/files#r356883111 and https://github.com/interchainio/tendermint-rs/pull/92/files#r356883796 are addressed we are ready to go!
Co-Authored-By: Ismail Khoffi <Ismail.Khoffi@gmail.com>
Co-Authored-By: Ismail Khoffi <Ismail.Khoffi@gmail.com>
|
|
…dermint-rs into release/v0.11.0
Added everything from v0.10. Moving forward we need to enforce PRs include these themselves. Perhaps we should adopt the conventions from Tendermint Core as we're accustomed to it.
Bumped the version in the Cargo.toml and the lib.rs - anything else needed? Not sure exactly what's required in a release.
Also should we wait to include #84?