Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module initialization order - readinitfiles and microphysics #49

Closed
fjansson opened this issue Feb 12, 2020 · 1 comment
Closed

module initialization order - readinitfiles and microphysics #49

fjansson opened this issue Feb 12, 2020 · 1 comment

Comments

@fjansson
Copy link
Contributor

Commit 4f35105 in version 4.2.1 changes the initialization order to

 call initmicrophysics
 call readinitfiles 

in modstartup.f90, line ~292.
This change breaks the simpleice2 microphysics, which needs rhobf profiles in its initialization routine to calculate some lookup tables.
If this order is necessary (why?), I can adapt the simpleice2 scheme, and calculate the lookup tables on each call - performance should not suffer much.

@huugouwersloot
Copy link
Contributor

This commit was a revert to the old situation, because the previously changed order caused bugs (it had something to do with scalars initialization which came to light, because chemistry stopped working properly). Some cases at WUR were going wrong because of this.
The order after this commit should be maintained and indeed a workaround for the new scheme should be applied

fjansson pushed a commit that referenced this issue Feb 13, 2020
…routine because of init order dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants