Let Profiling::ProfilingSection(std::string) constructor be explici…

…t and nodiscard (kokkos#6690) * Add nodiscard attribute to Profiling::ProfilingSection * Make Profiling::ProfilingSection constructor explicit
dalg24 · Jan 3, 2024 · f485cfa · f485cfa
1 parent 4078a0d
commit f485cfa
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/core/src/Kokkos_Profiling_ProfileSection.hpp b/core/src/Kokkos_Profiling_ProfileSection.hpp
@@ -29,12 +29,15 @@
 namespace Kokkos {
 namespace Profiling {
 
-class ProfilingSection {
+class [[nodiscard]] ProfilingSection {
  public:
   ProfilingSection(ProfilingSection const&) = delete;
   ProfilingSection& operator=(ProfilingSection const&) = delete;
 
-  ProfilingSection(const std::string& sectionName) {
+#if defined(__has_cpp_attribute) && __has_cpp_attribute(nodiscard) >= 201907
+  [[nodiscard]]
+#endif
+  explicit ProfilingSection(const std::string& sectionName) {
     Kokkos::Profiling::createProfileSection(sectionName, &secID);
   }