Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read configuration from YAML file #10

Merged
merged 2 commits into from
Jun 20, 2017
Merged

Read configuration from YAML file #10

merged 2 commits into from
Jun 20, 2017

Conversation

bersace
Copy link
Member

@bersace bersace commented Jun 20, 2017

Closes: #6

@codecov-io
Copy link

codecov-io commented Jun 20, 2017 •
edited

Codecov Report

Merging #10 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #10    +/-   ##
======================================
  Coverage     100%   100%            
======================================
  Files           3      5     +2     
  Lines          90    193   +103     
======================================
+ Hits           90    193   +103
Impacted Files Coverage Δ
ldap2pg/utils.py 100% <100%> (ø)
ldap2pg/config.py 100% <100%> (ø)
ldap2pg/script.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 870c34f...b0c4769. Read the comment docs.

@bersace bersace changed the title WIP: Read configuration from YAML file Read configuration from YAML file Jun 20, 2017
bersace
bersace commented Jun 20, 2017
View reviewed changes
tests/unit/test_config.py


def test_load(mocker):
environ = dict()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@julmon @pgiraud See how this test is the most mocked case. Other tests have very few mocks.

@bersace bersace merged commit 5bfb9d1 into dalibo:master Jun 20, 2017
@bersace bersace deleted the config branch June 20, 2017 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bersace @codecov-io