-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Layout reworking #81
Layout reworking #81
Conversation
Codecov Report
@@ Coverage Diff @@
## master #81 +/- ##
======================================
Coverage 0.57% 0.57%
======================================
Files 26 26
Lines 3850 3850
======================================
Hits 22 22
Misses 3828 3828
Continue to review full report at Codecov.
|
👍 Il y a un champ de recherche à droite (instances) et un à gauche (settings). Je vois bien une PR pour harmoniser ça :) Lundi, je teste tout ça ! |
Though I agree that consistency is important, I'd keep it different (position and styling) because:
|
I figured this out as well. Issue already created: #79 |
08da7b1
to
76defdf
Compare
Using request.uri to know if we're in manage feels a bit hackish
To be potentially replaced by breadcrumbs in the future
Ensure that layout looks almost the same event on large screens
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent outcome. It's quite big, but i'm confident.
Update default SSL cert & CA cert
The aim of this pull request is to re-organize the layout of the application. The main goal is to make sure it's easier to understand the difference between per-instance functionnalities and application level administrator features.
Work still need to be done to give the tool a visual identity (colors, etc...).
Also "manage" should be changed to "settings" ( #80 ) and "settings" plugin should be remaned "configuration" ( #75 ).
Here are some before/after screen shots:
![127 0 0 1-8888-home](https://cloud.githubusercontent.com/assets/319774/24050708/01a37260-0b30-11e7-9f1b-e95753851a5c.png)
![127 0 0 1-8888-manage-instances](https://cloud.githubusercontent.com/assets/319774/24050712/06399f02-0b30-11e7-990f-02faa3f55f28.png)
![127 0 0 1-8888-server-temboard-agent-96-2345-dashboard](https://cloud.githubusercontent.com/assets/319774/24050715/0984709c-0b30-11e7-9953-d81f90e93eca.png)
![127 0 0 1-8888-server-temboard-agent-96-2345-activity-running](https://cloud.githubusercontent.com/assets/319774/24050720/0b986b36-0b30-11e7-9247-2beee83e0ab7.png)
![127 0 0 1-8888-server-temboard-agent-96-2345-supervision-day 2](https://cloud.githubusercontent.com/assets/319774/24050724/0eebc2e2-0b30-11e7-8dc1-bebe8ac6201f.png)
![127 0 0 1-8888-server-temboard-agent-96-2345-settings-configuration](https://cloud.githubusercontent.com/assets/319774/24050726/117fcca6-0b30-11e7-9b21-097f1b6b3e27.png)