Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout reworking #81

Merged
merged 26 commits into from
Mar 20, 2017
Merged

Layout reworking #81

merged 26 commits into from
Mar 20, 2017

Conversation

pgiraud
Copy link
Member

@pgiraud pgiraud commented Mar 17, 2017

The aim of this pull request is to re-organize the layout of the application. The main goal is to make sure it's easier to understand the difference between per-instance functionnalities and application level administrator features.

Work still need to be done to give the tool a visual identity (colors, etc...).
Also "manage" should be changed to "settings" ( #80 ) and "settings" plugin should be remaned "configuration" ( #75 ).

Here are some before/after screen shots:
127 0 0 1-8888-home
127 0 0 1-8888-manage-instances
127 0 0 1-8888-server-temboard-agent-96-2345-dashboard
127 0 0 1-8888-server-temboard-agent-96-2345-activity-running
127 0 0 1-8888-server-temboard-agent-96-2345-supervision-day 2
127 0 0 1-8888-server-temboard-agent-96-2345-settings-configuration

@codecov-io
Copy link

codecov-io commented Mar 17, 2017

Codecov Report

Merging #81 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master     #81   +/-   ##
======================================
  Coverage    0.57%   0.57%           
======================================
  Files          26      26           
  Lines        3850    3850           
======================================
  Hits           22      22           
  Misses       3828    3828
Impacted Files Coverage Δ
temboardui/plugins/supervision/__init__.py 0% <ø> (ø) ⬆️
temboardui/handlers/notification.py 0% <ø> (ø) ⬆️
temboardui/plugins/activity/__init__.py 0% <ø> (ø) ⬆️
temboardui/plugins/settings/__init__.py 0% <ø> (ø) ⬆️
temboardui/plugins/dashboard/__init__.py 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8369990...b14324d. Read the comment docs.

@bersace
Copy link
Member

bersace commented Mar 17, 2017

👍

Il y a un champ de recherche à droite (instances) et un à gauche (settings). Je vois bien une PR pour harmoniser ça :)

Lundi, je teste tout ça !

@pgiraud
Copy link
Member Author

pgiraud commented Mar 20, 2017

Il y a un champ de recherche à droite (instances) et un à gauche (settings). Je vois bien une PR pour harmoniser ça :)

Though I agree that consistency is important, I'd keep it different (position and styling) because:

  • we are dealing with different components (table vs. list),
  • the behavior is different: on-the-fly filtering on key stroke vs. submitted form.

@pgiraud pgiraud closed this Mar 20, 2017
@pgiraud pgiraud reopened this Mar 20, 2017
@pgiraud pgiraud changed the title [WIP] Layout reworking Layout reworking Mar 20, 2017
@pgiraud pgiraud requested review from bersace and julmon March 20, 2017 11:01
@bersace
Copy link
Member

bersace commented Mar 20, 2017

In agent login page, i don't have Manage nor me top right items in the headerbar. Am i missing something ?

relecture-pr-81

@pgiraud
Copy link
Member Author

pgiraud commented Mar 20, 2017

In agent login page, i don't have Manage nor me top right items in the headerbar. Am i missing something ?

I figured this out as well. Issue already created: #79

@pgiraud pgiraud force-pushed the navbars branch 2 times, most recently from 08da7b1 to 76defdf Compare March 20, 2017 14:27
Copy link
Member

@bersace bersace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent outcome. It's quite big, but i'm confident.

@pgiraud pgiraud merged commit 02dd513 into dalibo:master Mar 20, 2017
@pgiraud pgiraud deleted the navbars branch March 20, 2017 15:15
bersace pushed a commit to bersace/temboard that referenced this pull request Mar 15, 2022
Update default SSL cert & CA cert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants