Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeFactory: fixed 'private final' methods to 'private'; #8

Merged
merged 1 commit into from
Aug 9, 2021

Conversation

giuspe
Copy link
Contributor

@giuspe giuspe commented Jul 30, 2021

I experienced a few annoying warnings while running wp-cli in a lando environment using PHP 8.0 (PHP 8.0.3 (cli) (built: Apr 10 2021 13:18:16) ( NTS )).

PHP Warning:  Private methods cannot be final as they are never overridden by other classes in /app/vendor/dallgoot/yaml/sources/NodeFactory.php on line 55

Warning: Private methods cannot be final as they are never overridden by other classes in /app/vendor/dallgoot/yaml/sources/NodeFactory.php on line 55
PHP Warning:  Private methods cannot be final as they are never overridden by other classes in /app/vendor/dallgoot/yaml/sources/NodeFactory.php on line 77

Warning: Private methods cannot be final as they are never overridden by other classes in /app/vendor/dallgoot/yaml/sources/NodeFactory.php on line 77
PHP Warning:  Private methods cannot be final as they are never overridden by other classes in /app/vendor/dallgoot/yaml/sources/NodeFactory.php on line 91

Warning: Private methods cannot be final as they are never overridden by other classes in /app/vendor/dallgoot/yaml/sources/NodeFactory.php on line 91
PHP Warning:  Private methods cannot be final as they are never overridden by other classes in /app/vendor/dallgoot/yaml/sources/NodeFactory.php on line 105

Warning: Private methods cannot be final as they are never overridden by other classes in /app/vendor/dallgoot/yaml/sources/NodeFactory.php on line 105
PHP Warning:  Private methods cannot be final as they are never overridden by other classes in /app/vendor/dallgoot/yaml/sources/NodeFactory.php on line 138

Warning: Private methods cannot be final as they are never overridden by other classes in /app/vendor/dallgoot/yaml/sources/NodeFactory.php on line 138
PHP Warning:  Private methods cannot be final as they are never overridden by other classes in /app/vendor/dallgoot/yaml/sources/NodeFactory.php on line 155

Warning: Private methods cannot be final as they are never overridden by other classes in /app/vendor/dallgoot/yaml/sources/NodeFactory.php on line 155
PHP Warning:  Private methods cannot be final as they are never overridden by other classes in /app/vendor/dallgoot/yaml/sources/NodeFactory.php on line 168

Warning: Private methods cannot be final as they are never overridden by other classes in /app/vendor/dallgoot/yaml/sources/NodeFactory.php on line 168

Simply changing private final to private of course solves the warnings.

@dallgoot dallgoot merged commit 096826f into dallgoot:master Aug 9, 2021
@dallgoot
Copy link
Owner

dallgoot commented Aug 9, 2021

Thank you for your work :)

@giuspe
Copy link
Contributor Author

giuspe commented Aug 9, 2021

Thank you for your work :)

definitely thank you for you work :)

@giuspe giuspe deleted the 2021.07/chore/php8-small-refactor branch August 9, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants