Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide the cell toolbox frame #92

Merged
merged 1 commit into from
Apr 4, 2015
Merged

Conversation

adl
Copy link
Contributor

@adl adl commented Mar 31, 2015

Looking into why I have some frame displayed around my Markdown cells in presentation mode (see picture below), I realize that 67c92cc did not completely solve #39.

frames

In a notebook, markdown cells are not framed unless the cell toolbox is active. So if we hide the cell toolbox, we should also hide the frame.

@damianavila
Copy link
Owner

I don't see the difference... can you post another image with the difference?

Also, because you are there, I see a border in the cells if the celltoolbar is "hided" by RISE... maybe you can hide it here too...

border

@adl
Copy link
Contributor Author

adl commented Apr 1, 2015

Removing the border you see around the markdown cells is precisely what this patch is about. Here is my example notebook after I apply the patch:

no-frame

I usually use Firefox. But since you didn't see any difference I've tested Chrome as well and it worked for me too.

@damianavila
Copy link
Owner

Removing the border you see around the markdown cells is precisely what this patch is about. Here is my example notebook after I apply the patch:

Jeje... we were talking about the same thing... going to test it today... if everything goes well, I will merge it.

damianavila added a commit that referenced this pull request Apr 4, 2015
hide the cell toolbox frame
@damianavila damianavila merged commit d92c26a into damianavila:master Apr 4, 2015
@damianavila
Copy link
Owner

Thanks @adl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants