Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling not activated "on the fly" when executing cell with an output making the slide longer. #647

Open
vmonteco opened this issue Nov 21, 2023 · 0 comments

Comments

@vmonteco
Copy link

Versions :

  • rise: 5.7.1
  • notebook: 6.0.0
    scroll is enabled in my config.

Summary/TL;DR :

I'm trying to make a presentation using Rise on a notebook. The scrollbar doesn't appear with the presentation flow so far as cells are interpreted to a long output that resizes the slide. How could I achieve that ?

Expected behaviors :

With fragments :

With long fragment appearing (space)

Scrollbar appears, making the slide scrollable.

With long fragments disappearing (space

Scrollbar disappears, making the slide non-scrollable.

With outputs :

Long output appearing

Scrollbar appears, making the slide scrollable.

Long output disappearing

Scrollbar disappears, making the slide non-scrollable.

Observed behavior :

With fragments :

With long fragment appearing (space)

Scrollbar doesn't appear, thus the slide isn't made scrollable.

With long fragments disappearing (space

N/A

With outputs :

Long output appearing

Scrollbar doesn't appear, thus the slide isn't made scrollable.

Long output disappearing

N/A

Partial workaround :

Without changing code, the only workaround I found is to change to an other slide and then to come back to the previous one (The scrollbar would appear).

Possible (and quick) solution for fragments :

In main.js, these changes at L647 make the scrollbar toggled by long fragments (dis)appearance.

              Reveal.addEventListener('fragmentshown', function(event) {
                setScrollingSlide();  /* Added line */
                autoSelectHook();
              });
              Reveal.addEventListener('fragmenthidden', function(event) {
                setScrollingSlide();  /* Added line */
                autoSelectHook();
              });

Lack of solution for outputs :

However, I didn't find a solution for outputs guess it could be more complicated as managing cells output events is probably not present by default in reveal.js.

I don't know the project very well, but interpreting cells doesn't seem to dispatch the slidechanged event that could be caught by RISE.

Would one have any idea to provide for this specific point ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant