Hide n' Seek 4.1.1 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(1) A bug occurred in which the Hide n' Seek UI failed to display on Indeed and LinkedIn, and then continued to fail to display even after reloading the tabs. Two uncaught promise rejection errors were logged: * "No tab with id: ##########." * "Frame with ID 0 was removed." Although I am not certain that these errors were the cause of the missing Hide n' Seek UI, I decided to simply handle rejections by adding a safeAwait utility function that handles the promises returned by several Chrome APIs, such as scripting.executeScript, scripting.insertCSS, etc.
(1) async was removed from the addListener callback because it was unnecessary. (2) Removed unnecessary storage arguments from calls to popup start methods
(1) async was removed from the runtime.onMessage.addListener callback because it is unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few days after updating from 4.0.0 to 4.1.0, the Hide n' Seek UI failed to display on Indeed and LinkedIn job search tabs.
This issue persisted even after reloading the tabs. Restarting Chrome resolved this issue, but what was the cause? Two uncaught promise rejection errors in background.js were logged:
However, I do not know if these errors caused the issue. These errors seem to occur when background.js queries tabs, then tries to inject the content script into applicable tabs, and fails. The cause of the injection failure may be due to the use of an incorrect or obsolete tab id, in which case the tab id must have changed or was lost between tab querying and script injection.