Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace any types #1919

Merged
merged 1 commit into from
Mar 25, 2024
Merged

refactor: replace any types #1919

merged 1 commit into from
Mar 25, 2024

Conversation

timdeschryver
Copy link
Contributor

This PR updates some any types to its runtime type or to unknown for errors.
Some tests are also updates to replace a "magic string" that contains any within the string.

@FabianGosebrink
Copy link
Collaborator

Nice, thanks!

@FabianGosebrink
Copy link
Collaborator

Are you finished and we can merge?

@timdeschryver
Copy link
Contributor Author

@FabianGosebrink there are still some any's left, but I already wanted to create this PR (and merge it) because I will be busy the next days.
One side note that I have is that this can result in a breaking change if some of these types are exposed and a user passes an invalid type.

@FabianGosebrink
Copy link
Collaborator

Let us merge and then see on main and the samples how it goes.

@FabianGosebrink FabianGosebrink merged commit 0fe5da3 into damienbod:main Mar 25, 2024
9 of 10 checks passed
@FabianGosebrink
Copy link
Collaborator

Thanks!

@timdeschryver timdeschryver deleted the replace-some-any-types branch March 25, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timdeschryver @FabianGosebrink