Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove items from local storage instead of writing empty string values #872

Merged
merged 1 commit into from
Oct 23, 2020
Merged

Remove items from local storage instead of writing empty string values #872

merged 1 commit into from
Oct 23, 2020

Conversation

OskarsPakers
Copy link
Contributor

Implements #746 by removing items from local storage for real instead of writing empty values to it.

@FabianGosebrink
Copy link
Collaborator

LGTM. Great job, thanks.

@damienbod
Copy link
Owner

@OskarsPakers Thanks for the PR, sorry for the slow answer, rather busy at the moment. Will test this and then merge

Greetings Damien

@damienbod damienbod merged commit db0f7a9 into damienbod:main Oct 23, 2020
@OskarsPakers OskarsPakers deleted the issues/746 branch October 23, 2020 18:28
@valdian valdian mentioned this pull request Oct 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabianGosebrink FabianGosebrink FabianGosebrink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OskarsPakers @FabianGosebrink @damienbod