New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace SimpleDateFormat with Joda Time to Improve Performance #30

Merged
merged 1 commit into from Sep 22, 2015

Conversation

Projects
None yet
3 participants
@asaph
Contributor

asaph commented Sep 18, 2015

The poor performance of java.text.SimpleDateFormat is well documented. Currently, every instantiation of UriTemplate creates an instance of SimpleDateFormat, whether it's needed or not. This pull request replaces the functionality of SimpleDateFormat with analogous functionality from Joda-Time which improves performance.

Note: A couple of methods and one field that exposed DateFormat and SimpleDateFormat, and that were part of this library's public interface, were marked as deprecated. I thought it better that the library shouldn't expose the details of its date formatting implementation. Incidentally, the deprecated methods didn't have test coverage (which this PR also adds). The deprecated items should be kept around until the next major version in order to maintain backwards compatibility with existing clients.

@buildhive

This comment has been minimized.

Show comment
Hide comment
@buildhive

buildhive commented Sep 18, 2015

Ryan J. McDonough » Handy-URI-Templates #122 SUCCESS
This pull request looks good
(what's this?)

@damnhandy damnhandy added this to the Future milestone Sep 20, 2015

damnhandy added a commit that referenced this pull request Sep 22, 2015

Merge pull request #30 from asaph/joda-time
Replace SimpleDateFormat with Joda Time to Improve Performance

@damnhandy damnhandy merged commit fcead60 into damnhandy:master Sep 22, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@damnhandy damnhandy modified the milestones: 2.1, Future Sep 22, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment