Replace SimpleDateFormat with Joda Time to Improve Performance #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ryan J. McDonough » Handy-URI-Templates #122 SUCCESS |
damnhandy
added a commit
that referenced
this pull request
Sep 22, 2015
Replace SimpleDateFormat with Joda Time to Improve Performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The poor performance of
java.text.SimpleDateFormatis well documented. Currently, every instantiation ofUriTemplatecreates an instance ofSimpleDateFormat, whether it's needed or not. This pull request replaces the functionality ofSimpleDateFormatwith analogous functionality from Joda-Time which improves performance.Note: A couple of methods and one field that exposed
DateFormatandSimpleDateFormat, and that were part of this library's public interface, were marked as deprecated. I thought it better that the library shouldn't expose the details of its date formatting implementation. Incidentally, the deprecated methods didn't have test coverage (which this PR also adds). The deprecated items should be kept around until the next major version in order to maintain backwards compatibility with existing clients.