Use string literals for JSON object keys #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The source map seems to be ignored in Chrome (and other browsers) unless the object keys are string literals. Making this change locally resolved that particular issue.
damonsmith
added a commit
that referenced
this pull request
Oct 2, 2014
Use string literals for JSON object keys
|
Amazing! Thank you so much, I'm so used to using unquoted keys in JS I forgot that the JSON spec mandates that they must be quoted. I'll have a go of it now on a test project where I can tell if the line numbers are right. Also I'll move your code out at some stage and build it as a provided maven dependency with fat jar config. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The source map seems to be ignored in Chrome (and other browsers)
unless the object keys are string literals. Making this change locally
resolved that particular issue.