Fix undef warnings

dams · Feb 14, 2012 · ae346c3 · ae346c3
1 parent cf2618d
commit ae346c3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/Changes b/Changes
@@ -1,3 +1,7 @@
+  - Fix Log::Message::Structured::Stringify::Sprintf warnings when values
+    in the sprintf string are undef. They are now literally printed as
+    'undef'
+
 0.002
   - Fix docs for Stringify::Sprintf
 

diff --git a/lib/Log/Message/Structured/Stringify/Sprintf.pm b/lib/Log/Message/Structured/Stringify/Sprintf.pm
@@ -28,7 +28,7 @@ role {
         my $self = shift;
         # FIXME - Find the correct reader name rather than assuming
         #         attribute name == accessor name.
-        sprintf($format_string, map { $self->$_ } @attributes);
+        sprintf($format_string, map { my $val = $self->$_; $val = 'undef' unless defined $val; $val } @attributes);
     };
 };