Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search UI Redesign #2046

Closed
jb55 opened this issue Mar 13, 2024 · 4 comments · May be fixed by #2211
Closed

Search UI Redesign #2046

jb55 opened this issue Mar 13, 2024 · 4 comments · May be fixed by #2211
Assignees
@ericholguin
Labels
search

Comments

@jb55
Copy link
Collaborator

jb55 commented Mar 13, 2024

When scrolling after doing a note search, it doesn't hide the keyboard like we do in the global search view. We still need to refactor these views so they are the same, but in the meantime this is very annoying to me.
@jb55 jb55 added the search label Mar 13, 2024
@jb55
Copy link
Collaborator Author

jb55 commented Mar 13, 2024

cc @ericholguin I can't remember who figured out how to do this in the origin search view

@ericholguin
Copy link
Collaborator

I used a state variable. Will also add that to the home search view.

@ericholguin ericholguin self-assigned this Mar 14, 2024
@alltheseas alltheseas changed the title Auto-hide keyboard when scrolling after searching note Search UI Redesign Mar 25, 2024
ericholguin added a commit to ericholguin/damus that referenced this issue Mar 26, 2024
@ericholguin
ux: Local Search Redesign
54c8297 
This patch redesigns the pull down search view by improving the search bar.
In addition minor ux/ui improvements are done such as:
- hiding the timeline when the user is searching
- hiding the custom picker when the user is searching
- text suggesting the user try searching for keywords
- dismiss the keyboard on scroll

Testing
——
iPhone 15 Pro Max (17.3.1) Dark Mode:
https://v.nostr.build/WGGzk.mp4

iPhone SE (3rd generation) (16.4) Light Mode:
https://v.nostr.build/Q77Vv.mp4

——

Fixes: damus-io#2074
Closes: damus-io#2046
Changelog-Fixed: search results remaining after empty search
Changelog-Changed: local search ux/ui

Signed-off-by: ericholguin <ericholguin@apache.org>
ericholguin added a commit to ericholguin/damus that referenced this issue Mar 26, 2024
@ericholguin
ux: Local Search Redesign
57782f3 
This patch redesigns the pull down search view by improving the search bar.
In addition minor ux/ui improvements are done such as:
- hiding the timeline when the user is searching
- hiding the custom picker when the user is searching
- text suggesting the user try searching for keywords
- dismiss the keyboard on scroll

Testing
——
iPhone 15 Pro Max (17.3.1) Dark Mode:
https://v.nostr.build/WGGzk.mp4

iPhone SE (3rd generation) (16.4) Light Mode:
https://v.nostr.build/Q77Vv.mp4

——

Fixes: damus-io#2074
Closes: damus-io#2046
Changelog-Fixed: search results remaining after empty search
Changelog-Changed: local search ux/ui

Signed-off-by: ericholguin <ericholguin@apache.org>

PATCH CHANGELOG:
V1 -> V2: addressed review comments regarding state variables in ContentView and stuttering search bar
@alltheseas
Copy link
Collaborator

Related: #2116

@jb55 jb55 mentioned this issue May 6, 2024
Draft
@jb55
Copy link
Collaborator Author

jb55 commented May 6, 2024

New tracking issue is:

@jb55 jb55 closed this as completed May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericholguin ericholguin

Labels
search
Projects
Damus Roadmap 🛣️
Status: In Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ux: Local Search Redesign ericholguin/damus
3 participants
@jb55 @ericholguin @alltheseas