Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should search results remain after keyword is deleted in search bar #2074

Open
Tracked by #2205
alltheseas opened this issue Mar 19, 2024 · 2 comments · May be fixed by #2211
Open
Tracked by #2205

Should search results remain after keyword is deleted in search bar #2074

alltheseas opened this issue Mar 19, 2024 · 2 comments · May be fixed by #2211
Assignees
@ericholguin
Labels
design Design exploration & definition is required search

Comments

@alltheseas
Copy link
Collaborator

alltheseas commented Mar 19, 2024 •
edited

image
@alltheseas alltheseas added design Design exploration & definition is required search labels Mar 19, 2024
ericholguin added a commit to ericholguin/damus that referenced this issue Mar 26, 2024
@ericholguin
ux: Local Search Redesign
54c8297 
This patch redesigns the pull down search view by improving the search bar.
In addition minor ux/ui improvements are done such as:
- hiding the timeline when the user is searching
- hiding the custom picker when the user is searching
- text suggesting the user try searching for keywords
- dismiss the keyboard on scroll

Testing
——
iPhone 15 Pro Max (17.3.1) Dark Mode:
https://v.nostr.build/WGGzk.mp4

iPhone SE (3rd generation) (16.4) Light Mode:
https://v.nostr.build/Q77Vv.mp4

——

Fixes: damus-io#2074
Closes: damus-io#2046
Changelog-Fixed: search results remaining after empty search
Changelog-Changed: local search ux/ui

Signed-off-by: ericholguin <ericholguin@apache.org>
ericholguin added a commit to ericholguin/damus that referenced this issue Mar 26, 2024
@ericholguin
ux: Local Search Redesign
57782f3 
This patch redesigns the pull down search view by improving the search bar.
In addition minor ux/ui improvements are done such as:
- hiding the timeline when the user is searching
- hiding the custom picker when the user is searching
- text suggesting the user try searching for keywords
- dismiss the keyboard on scroll

Testing
——
iPhone 15 Pro Max (17.3.1) Dark Mode:
https://v.nostr.build/WGGzk.mp4

iPhone SE (3rd generation) (16.4) Light Mode:
https://v.nostr.build/Q77Vv.mp4

——

Fixes: damus-io#2074
Closes: damus-io#2046
Changelog-Fixed: search results remaining after empty search
Changelog-Changed: local search ux/ui

Signed-off-by: ericholguin <ericholguin@apache.org>

PATCH CHANGELOG:
V1 -> V2: addressed review comments regarding state variables in ContentView and stuttering search bar
@alltheseas
Copy link
Collaborator Author

@ericholguin did you solve this one in your search updates?

This was referenced May 6, 2024
Draft
Open
@jb55
Copy link
Collaborator

jb55 commented May 6, 2024

I found that non-exact matches would pop results in and out, so I made it show the last successful search result. we just need to make this a bit more clear what result was the matching one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericholguin ericholguin

Labels
design Design exploration & definition is required search
Projects
Damus Roadmap 🛣️
Status: Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ux: Local Search Redesign ericholguin/damus
3 participants
@jb55 @ericholguin @alltheseas