Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nip10 reply support #2239

Closed
Tracked by #2228
jb55 opened this issue May 9, 2024 · 1 comment
Closed
Tracked by #2228

nip10 reply support #2239

jb55 opened this issue May 9, 2024 · 1 comment
Assignees
@jb55
Labels
interop interoperability and compatibility with other nostr apps
Milestone
1.8 relay fix + v...

Comments

@jb55
Copy link
Collaborator

jb55 commented May 9, 2024

I realize we probably need this, and I've been working on it today. adding some tests and will PR soon
@jb55 jb55 added this to the 1.8 relay fix + video player milestone May 9, 2024
@jb55 jb55 added the interop interoperability and compatibility with other nostr apps label May 9, 2024
@jb55 jb55 self-assigned this May 9, 2024
@alltheseas
Copy link
Collaborator

relates to #2022

@alltheseas alltheseas mentioned this issue May 9, 2024
Open
15 tasks
@jb55 jb55 mentioned this issue May 9, 2024
Merged
@jb55 jb55 closed this as completed in 514a053 May 9, 2024
jb55 added a commit that referenced this issue May 10, 2024
@jb55
nip10: marker replies
896cdf0 
This should drastically increase compatibility for damus replies in
other clients.

Also filter non-pubkey references when replying so we don't run into the
q-tag bug.

Changelog-Added: Added nip10 marker replies
Changelog-Fixed: Fixed issue where some replies were including the q tag
Fixes: #2239
Fixes: #2233
Signed-off-by: William Casarin <jb55@jb55.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jb55 jb55

Labels
interop interoperability and compatibility with other nostr apps
Projects
Damus Roadmap 🛣️
Status: Live
Milestone
1.8 relay fix + video player
Development

No branches or pull requests
2 participants
@jb55 @alltheseas