nip10: marker replies #2241
Merged
nip10: marker replies #2241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should drastically increase compatibility for damus replies in other clients. Also filter non-pubkey references when replying so we don't run into the q-tag bug. Changelog-Added: Added nip10 marker replies Changelog-Fixed: Fixed issue where some replies were including the q tag Fixes: #2239 Fixes: #2233 Signed-off-by: William Casarin <jb55@jb55.com>
I noticed a few clients do this even though its not valid. Let's handle it. Signed-off-by: William Casarin <jb55@jb55.com>
These are overlapping concepts, lets slowly get rid of EventRef Signed-off-by: William Casarin <jb55@jb55.com>
Our nip10 logic looks for notes only in the in-memory cache. This means sometimes threads don't get fully loaded if for whatever reason it's in the nostrdb cache but not in-memory. Ideally we would just remove our in-memory cache, but for now let's just hack it so it falls back to nostrdb and makes an owned note. Changelog-Fixed: Fixed threads not loading sometimes Signed-off-by: William Casarin <jb55@jb55.com>
|
wow 4ac3da7 fixed so many broken threads. I integrated nostrdb so that it can crawl a thread no matter if the tags are correct or not. |
This was referenced May 9, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should drastically increase compatibility for damus replies in other clients.
Also filter non-pubkey references when replying so we don't run into the q-tag bug.
Changelog-Added: Added nip10 marker replies
Changelog-Fixed: Fixed issue where some replies were including the q tag
Fixes: