New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amend typos in keys.lua #543

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@hugeblank

hugeblank commented May 8, 2018

Skimming through the CC API for an emulator project and found this bug rendering the game "literally unplayable". I decided to take this game-breaking issue into my own hands and repair it. You're welcome CC.

In other words this is the worst reason to receive a contributor tag.

amend typo in keys.lua
The most important commit that CC has ever seen.
@@ -53,6 +53,7 @@ for nKey, sKey in pairs( tKeys ) do
keys[sKey] = nKey
end
keys["return"] = keys.enter
keys.scollLock = keys.scrollLock

This comment has been minimized.

@lupus590

lupus590 May 8, 2018

Contributor

You might as well change this to keys["scrollLock"] to be consistent with the line above.

This comment has been minimized.

@SquidDev

SquidDev May 8, 2018

Contributor

I believe it's only ["return"] because that is a Lua keyword, and so keys.return is invalid syntax.

@@ -53,6 +53,7 @@ for nKey, sKey in pairs( tKeys ) do
keys[sKey] = nKey
end
keys["return"] = keys.enter
keys.scollLock = keys.scrollLock

This comment has been minimized.

@KnightMiner

KnightMiner May 9, 2018

Probably should add a comment here explaining why the old name is kept for after this is merged, something like "typo kept to avoid a breaking change"

This comment has been minimized.

@hugeblank

hugeblank May 9, 2018

I thought about it, I wasn’t sure if it was worth commenting though. I’ll add it when I get the chance.

This comment has been minimized.

@hugeblank

hugeblank May 18, 2018

@KnightMiner I should mention I did this in the most recent commit.

amend additional typo in keys.lua
- fixed circumflex typo: you can now cîrcûmflêx on all your friends
- added comment making it clearer that the following lines are intended for backwards compatibility.
@hugeblank

This comment has been minimized.

hugeblank commented May 10, 2018

Found another typo, you can now cîrcûm FLÊX (correctly) on all your friends.

@hugeblank hugeblank changed the title from amend typo in keys.lua to amend typos in keys.lua May 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment