amend typos in keys.lua #543
Conversation
The most important commit that CC has ever seen.
| @@ -53,6 +53,7 @@ for nKey, sKey in pairs( tKeys ) do | |||
| keys[sKey] = nKey | |||
| end | |||
| keys["return"] = keys.enter | |||
| keys.scollLock = keys.scrollLock | |||
There was a problem hiding this comment.
You might as well change this to keys["scrollLock"] to be consistent with the line above.
There was a problem hiding this comment.
I believe it's only ["return"] because that is a Lua keyword, and so keys.return is invalid syntax.
| @@ -53,6 +53,7 @@ for nKey, sKey in pairs( tKeys ) do | |||
| keys[sKey] = nKey | |||
| end | |||
| keys["return"] = keys.enter | |||
| keys.scollLock = keys.scrollLock | |||
There was a problem hiding this comment.
Probably should add a comment here explaining why the old name is kept for after this is merged, something like "typo kept to avoid a breaking change"
There was a problem hiding this comment.
I thought about it, I wasn’t sure if it was worth commenting though. I’ll add it when I get the chance.
There was a problem hiding this comment.
@KnightMiner I should mention I did this in the most recent commit.
- fixed circumflex typo: you can now cîrcûmflêx on all your friends - added comment making it clearer that the following lines are intended for backwards compatibility.
|
Found another typo, you can now cîrcûm FLÊX (correctly) on all your friends. |
amend typo in keys.lua
Skimming through the CC API for an emulator project and found this bug rendering the game "literally unplayable". I decided to take this game-breaking issue into my own hands and repair it. You're welcome CC.
In other words this is the worst reason to receive a contributor tag.