Improvement to redis socket security #121
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, permissions for the redis socket are 777; access for everyone. This presents a security vulnerability that allows any user to read cached data. I've modified the permissions to 770. To facilitate this I moved the socket to
/var/run/redis
, which is a directory with ownershipredis:redis
. This solves the problem of having it in/tmp
, where the ownership of the socket isredis:wheel
. The change in directory permissions allows other users to be added to theredis
group without unnecessarily providing a user with the permissions ofwheel
.Namely, it allows the
www
user to be added to theredis
group, which allows the removal of any permissions to "other" users.If you have any feedback let me know :)