fixed #24

- added reproducing issue - fixed the code to use invariant culture
danbarua · Jul 30, 2012 · a6b89d0 · a6b89d0
1 parent 25e77be
commit a6b89d0
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/src/ServiceStack.Redis/RedisClient_SortedSet.cs b/src/ServiceStack.Redis/RedisClient_SortedSet.cs
@@ -12,6 +12,7 @@
 
 using System;
 using System.Collections.Generic;
+using System.Globalization;
 using System.Linq;
 using ServiceStack.DesignPatterns.Model;
 using ServiceStack.Redis.Support;
@@ -218,7 +219,7 @@ private static IDictionary<string, double> CreateSortedScoreMap(byte[][] multiDa
 			{
 				var key = multiDataList[i].FromUtf8Bytes();
 				double value;
-				double.TryParse(multiDataList[i + 1].FromUtf8Bytes(), out value);
+                double.TryParse(multiDataList[i + 1].FromUtf8Bytes(), NumberStyles.Any, CultureInfo.InvariantCulture, out value);
 				map[key] = value;
 			}
 

diff --git a/tests/ServiceStack.Redis.Tests/RedisClientSortedSetTests.cs b/tests/ServiceStack.Redis.Tests/RedisClientSortedSetTests.cs
@@ -1,6 +1,8 @@
 using System;
 using System.Collections.Generic;
+using System.Globalization;
 using System.Linq;
+using System.Threading;
 using NUnit.Framework;
 using ServiceStack.Common.Extensions;
 using ServiceStack.Text;
@@ -233,6 +235,18 @@ public void Can_IncrementItemInSortedSet()
 			Console.WriteLine(map.Dump());
 		}
 
+        [Test]
+        public void Can_WorkInSortedSetUnderDifferentCulture()
+        {
+            Thread.CurrentThread.CurrentCulture = CultureInfo.CreateSpecificCulture("ru-RU");
+            Redis.AddItemToSortedSet(SetId, "key", 123.22);
+
+            var map = Redis.GetAllWithScoresFromSortedSet(SetId);
+
+            Assert.AreEqual(123.22, map["key"]);
+        }
+
+
 		[Ignore("Not implemented yet")]
 		[Test]
 		public void Can_GetRangeFromSortedSetByHighestScore_from_sorted_set()