Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove janitor user level #2417

Closed
r888888888 opened this issue Jun 25, 2015 · 6 comments
Closed

Remove janitor user level #2417

r888888888 opened this issue Jun 25, 2015 · 6 comments
Labels

Comments

@r888888888
Copy link
Collaborator

The right to approve posts should not be tied to user level. Some things must be done:

  • Create a new user flag for can_approve_posts
  • Move existing janitor role checks to either builder or moderator
  • Migrate existing janitors
  • Rework janitor trials to support the user flag
@Type-kun
Copy link
Collaborator

Will there be any indication on user page that the user can approve posts? What about username coloring, perhaps add some icon to approvers?

@r888888888
Copy link
Collaborator Author

I think adding a unique color/icon is kinda overkill, considering anyone could just view their profile page to see the exact permissions they have.

ToksT added a commit that referenced this issue Jul 1, 2015
@ToksT
Copy link
Contributor

ToksT commented Jul 1, 2015

I think it would be convenient so you can tell who's an approver immediately, rather than having to go to the profile page of each individual person you see in order to tell if they're an approver.

If we're not going add an official style I added a css class to approver usernames so custom css can be used for this. I'll probably use something like this for my css:

.user-post-approver::after { content: " ✔"; font-size: 85%; color: green; }

@Type-kun
Copy link
Collaborator

Type-kun commented Jul 3, 2015

Uh, are you sure approving/rejecting aliases/burs/implications should be builder+, not mod+? It seems pretty critical to me.

@ToksT
Copy link
Contributor

ToksT commented Jul 3, 2015

Uh, are you sure approving/rejecting aliases/burs/implications should be builder+, not mod+? It seems pretty critical to me.

Approving is admin only, not builder+ nor mod+.

Rejecting used to be janitor+ but is now builder+.

@ToksT
Copy link
Contributor

ToksT commented Jul 3, 2015

Editing is also builder+ now.

And I don't think it's much of an issue, I'm often the one that points out that someone messed up the format of a request so this would let me or other builder+ users to fix this type of mistake from new users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants